albertogpz commented on a change in pull request #6663:
URL: https://github.com/apache/geode/pull/6663#discussion_r679017707
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -1404,13 +1404,19 @@ void
peekEventsFromIncompleteTransactions(List<GatewaySenderEventImpl> batch,
}
}
if (incompleteTransactionIdsInBatch.size() == 0 ||
- retries++ == GET_TRANSACTION_EVENTS_FROM_QUEUE_RETRIES) {
+ retries >= sender.getRetriesToGetTransactionEventsFromQueue()) {
break;
}
+ retries++;
+ try {
+ Thread.sleep(GET_TRANSACTION_EVENTS_FROM_QUEUE_WAIT_TIME_MS);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ }
}
if (incompleteTransactionIdsInBatch.size() > 0) {
- logger.warn("Not able to retrieve all events for transactions: {} after
{} retries",
- incompleteTransactionIdsInBatch, retries);
+ logger.warn("Not able to retrieve all events for transactions: {} after
{} retries of {}ms" +
+ incompleteTransactionIdsInBatch, retries,
GET_TRANSACTION_EVENTS_FROM_QUEUE_WAIT_TIME_MS);
Review comment:
Yes, it is as you say. This is a best effort action. If in a
"reasonable" time the transaction cannot be completed (and one reason could be
because it is impossible due to the contents of the transaction and the
configuration of gateway senders), then you go on with sending the batch but
you log a warning and increment a counter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
