albertogpz commented on a change in pull request #6663:
URL: https://github.com/apache/geode/pull/6663#discussion_r693816325



##########
File path: 
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
##########
@@ -500,4 +516,12 @@
    */
   void setGatewayEventFilters(List<GatewayEventFilter> filters);
 
+  /**
+   * Set the number of retries to get transaction events
+   * for this GatewaySender when GroupTransactionEvents
+   * is set.
+   *
+   */
+  void setRetriesToGetTransactionEventsFromQueue(int retries);
+
 }

Review comment:
       Actually, that method is invoked from `WANTestBase::createSender()` when 
`groupTransactionEvents` is `true`.
   I added it to be able to use a high value for the parameter to avoid 
flakyness in test cases that have `groupTransactionEvents` set to true. Setting 
this parameter for test cases using a System Property would not be very 
convenient.
   For uses other than test cases, I think that having the System Property 
would be enough.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to