pivotal-jbarrett commented on a change in pull request #6702:
URL: https://github.com/apache/geode/pull/6702#discussion_r680262446
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
##########
@@ -787,39 +783,40 @@ private void notLockGrantorId(LockGrantorId
notLockGrantorId, long timeToWait,
if (logger.isTraceEnabled(LogMarker.DLS_VERBOSE)) {
Review comment:
It is intentional to avoid that trap. In the past we have been bad about
changing units of time and not correcting the math at all the call points.
While all the current usages always use milliseconds that may not be the case
in the future. Time is hard and has bit us in the rear a few too many times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
