pivotal-jbarrett commented on a change in pull request #6702:
URL: https://github.com/apache/geode/pull/6702#discussion_r680263094
##########
File path:
geode-core/src/main/java/org/apache/geode/distributed/internal/locks/DLockService.java
##########
@@ -1435,10 +1429,10 @@ public boolean lockInterruptibly(final Object name,
final long waitTimeMillis,
name, token);
}
reentrant = true;
- if (reentrant && disallowReentrant) {
+ if (disallowReentrant) {
throw new IllegalStateException(
String.format("%s attempted to reenter non-reentrant lock
%s",
- new Object[] {Thread.currentThread(), token}));
+ Thread.currentThread(), token));
}
recursionBefore = token.getRecursion();
lockId = token.getLeaseId(); // keep lockId
Review comment:
Again, not trying to address all warnings just most of the low hanging
automated cleanups. Without sufficient testing in these areas I am going to
tread very lightly on things that can affect readability and/or concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
