kirklund commented on a change in pull request #6746:
URL: https://github.com/apache/geode/pull/6746#discussion_r691647015



##########
File path: 
geode-junit/src/main/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTestBase.java
##########
@@ -305,6 +297,10 @@ private void 
serializeAndDeserializeSanctionedObject(Object object) throws Excep
     BufferDataOutputStream outputStream = new 
BufferDataOutputStream(KnownVersion.CURRENT);
     try {
       serializeObject(object, outputStream);
+    } catch (RemoteException e) {
+      System.out.println(object.getClass().getName() +
+          " is a java.rmi.server.RemoteObject which is not supported by 
AnalyzeSerializables");
+      return;

Review comment:
       Note: geode-dunit is the only module that uses RMI. Now that geode-dunit 
uses sanctioned serializables, a couple RMI classes are fed into this test. 
Supporting java.rmi.server.RemoteObject would require extra finesse that this 
test doesn't do and it's not worth implementing it for now.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to