kirklund commented on a change in pull request #6746:
URL: https://github.com/apache/geode/pull/6746#discussion_r691647015
##########
File path:
geode-junit/src/main/java/org/apache/geode/codeAnalysis/AnalyzeSerializablesJUnitTestBase.java
##########
@@ -305,6 +297,10 @@ private void
serializeAndDeserializeSanctionedObject(Object object) throws Excep
BufferDataOutputStream outputStream = new
BufferDataOutputStream(KnownVersion.CURRENT);
try {
serializeObject(object, outputStream);
+ } catch (RemoteException e) {
+ System.out.println(object.getClass().getName() +
+ " is a java.rmi.server.RemoteObject which is not supported by
AnalyzeSerializables");
+ return;
Review comment:
Note: geode-dunit is the only module that uses RMI. Now that geode-dunit
uses sanctioned serializables, a couple RMI classes are fed into this test.
Supporting java.rmi.server.RemoteObject would require extra finesse that this
test doesn't do and it's not worth implementing it for now.
##########
File path:
geode-memcached/src/integrationTest/java/org/apache/geode/internal/memcached/MemcachedSanctionedSerializablesServiceIntegrationTest.java
##########
@@ -14,30 +14,36 @@
*/
package org.apache.geode.internal.memcached;
+import static org.assertj.core.api.Assertions.assertThat;
+
import java.io.IOException;
import java.net.URL;
import java.util.Collection;
-import org.apache.geode.distributed.internal.DistributedSystemService;
-import org.apache.geode.distributed.internal.InternalDistributedSystem;
-import org.apache.geode.internal.InternalDataSerializer;
-import org.apache.geode.internal.classloader.ClassPathLoader;
+import org.junit.Test;
-public class MemcachedDistributedSystemService implements
DistributedSystemService {
- @Override
- public void init(InternalDistributedSystem internalDistributedSystem) {
+import org.apache.geode.internal.serialization.SanctionedSerializablesService;
- }
+public class MemcachedSanctionedSerializablesServiceIntegrationTest {
Review comment:
Local git diffs are correct, but github is incorrectly showing that
MemcachedDistributedSystemService changed to
MemcachedSanctionedSerializablesServiceIntegrationTest.
##########
File path:
geode-memcached/src/main/java/org/apache/geode/internal/memcached/MemcachedSanctionedSerializablesService.java
##########
@@ -12,20 +12,16 @@
* or implied. See the License for the specific language governing permissions
and limitations under
* the License.
*/
-package org.apache.geode.codeAnalysis;
+package org.apache.geode.internal.memcached;
+import java.net.URL;
-import org.apache.geode.gfsh.internal.management.GfshDistributedSystemService;
+import org.apache.geode.internal.serialization.SanctionedSerializablesService;
-public class AnalyzeGfshSerializablesJUnitTest extends
AnalyzeSerializablesJUnitTestBase {
+public class MemcachedSanctionedSerializablesService implements
SanctionedSerializablesService {
Review comment:
Local git diffs are correct, but github is incorrectly showing that
AnalyzeGfshSerializablesJUnitTest changed to
MemcachedSanctionedSerializablesService.
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/SerializationSanctionedSerializablesService.java
##########
@@ -12,15 +12,14 @@
* or implied. See the License for the specific language governing permissions
and limitations under
* the License.
*/
-package org.apache.geode.distributed.internal;
+package org.apache.geode.internal.serialization;
-import java.io.IOException;
-import java.util.Collection;
+import java.net.URL;
-public interface DistributedSystemService {
- void init(InternalDistributedSystem internalDistributedSystem);
+public class SerializationSanctionedSerializablesService implements
SanctionedSerializablesService {
Review comment:
Local git diffs are correct, but github is incorrectly showing that
DistributedSystemService changed to SerializationSanctionedSerializablesService.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
