kirklund commented on a change in pull request #6746:
URL: https://github.com/apache/geode/pull/6746#discussion_r690753606



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java
##########
@@ -198,16 +201,23 @@
           + 
";org.apache.shiro.*;org.apache.shiro.authz.*;org.apache.shiro.authc.*"
 
           // export logs
-          + ";org.apache.logging.log4j.Level" + 
";org.apache.logging.log4j.spi.StandardLevel"
+          + ";org.apache.logging.log4j.Level"
+          + ";org.apache.logging.log4j.spi.StandardLevel"
 
           // jar deployment
-          + ";com.sun.proxy.$Proxy*" + 
";com.healthmarketscience.rmiio.RemoteInputStream"
-          + ";javax.rmi.ssl.SslRMIClientSocketFactory" + 
";javax.net.ssl.SSLHandshakeException"
+          + ";com.sun.proxy.$Proxy*"
+          + ";com.healthmarketscience.rmiio.RemoteInputStream"
+          + ";javax.rmi.ssl.SslRMIClientSocketFactory"
+          + ";javax.net.ssl.SSLHandshakeException"
           + 
";javax.net.ssl.SSLException;sun.security.validator.ValidatorException"
           + ";sun.security.provider.certpath.SunCertPathBuilderException"
 
           // geode-modules
-          + ";org.apache.geode.modules.util.SessionCustomExpiry" + ";";
+          + ";org.apache.geode.modules.util.SessionCustomExpiry"
+
+          // springframework
+          + ";org.springframework.**"

Review comment:
       Please notice this addition! If validate-serializable-objects is turned 
on in the Locator, Pulse will require some number of springframework classes. 
We should probably try to narrow this down to specific .jars or packages, but 
because of transitive dependencies, I don't know a good way to create a 
comprehensive list.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to