dschneider-pivotal commented on a change in pull request #6768:
URL: https://github.com/apache/geode/pull/6768#discussion_r697725184
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java
##########
@@ -145,16 +153,16 @@ public boolean equals(Object o) {
return false;
}
- for (Map.Entry<byte[], OrderedSetEntry> entry : members.entrySet()) {
+ return members.fastWhileEach(entry -> {
Review comment:
Good point. I realized these names are fine but in this case we should
be doing "fastWhileEachValue" instead of "fastWhileEach". We don't need the
keys from members only the values since each value has both its member and
score. After changing to fastWhileEachValue the names now make sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
