dschneider-pivotal commented on a change in pull request #6768:
URL: https://github.com/apache/geode/pull/6768#discussion_r697726938
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisHash.java
##########
@@ -190,11 +198,11 @@ public int hdel(Region<RedisKey, RedisData> region,
RedisKey key, List<byte[]> f
}
public Collection<byte[]> hgetall() {
- ArrayList<byte[]> result = new ArrayList<>(hash.size());
- for (Map.Entry<byte[], byte[]> entry : hash.entrySet()) {
+ ArrayList<byte[]> result = new ArrayList<>(hash.size() * 2);
Review comment:
You may be right about this but I think I'll not include that in this
pr. I'm actually okay with how this class currently does it because the return
type is not ArrayList.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
