jinmeiliao commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r711277696
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientUpdater.java
##########
@@ -1763,6 +1767,19 @@ private void processMessages() {
}
}
+ private void handleAuthenticate(Message clientMessage) {
+ // if client is in multi-user mode, the CacheClientUpdator (at this point)
+ // can't differentiate which user this message is intended to. so throw
exception for now
+ // one possible solution is re-authenticate all users in this client
+ if (qManager.getPool().getMultiuserAuthentication()) {
+ throw new UnsupportedOperationException(
Review comment:
I didn't put this "re-authenticate" in my initial implementation because
1) if we get this message from the server, no other message will be
delivered to this client until we re-authenticate back successfully.
2) even if we put it in a separate thread, we will need to see if any
exception happens on that thread and if so, we need to close the thread anyway.
I haven't seen much benefit of putting this in a different thread yet, but I
don't see much harm in putting in a different thread either. Since it can go
either way, I much rather wait for this PR to settle before I put in more
"improvement".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
