agingade commented on a change in pull request #6835:
URL: https://github.com/apache/geode/pull/6835#discussion_r712613475
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/CacheClientUpdater.java
##########
@@ -1763,6 +1767,19 @@ private void processMessages() {
}
}
+ private void handleAuthenticate(Message clientMessage) {
+ // if client is in multi-user mode, the CacheClientUpdator (at this point)
+ // can't differentiate which user this message is intended to. so throw
exception for now
+ // one possible solution is re-authenticate all users in this client
+ if (qManager.getPool().getMultiuserAuthentication()) {
+ throw new UnsupportedOperationException(
Review comment:
@jinmeiliao my concerns are:
Point 1:
Yes that is true.
Point 2:
If there is exception, then thread can handle according to the exception.
And if it needs to close the connection, it can. But what I am trying to convey
here is the CacheClientUpdater thread is not meant to be used for server cache
operation. And currently its handling the exception based on the expectation of
server to client communication. I am not seeing any tests/code changes in
CacheClientUpdater exception handling to handle the exception from client to
server communication which this PR is introducing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
