nonbinaryprogrammer commented on a change in pull request #6861: URL: https://github.com/apache/geode/pull/6861#discussion_r714326220
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZInterStoreExecutor.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public class ZInterStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<RedisKey> sourceKeys = new ArrayList<>((int) numKeys); + List<Double> weights = new ArrayList<>((int) numKeys); Review comment: it cannot. the weights must be able to be null, and we need to be able to check if the list is empty, and since it's pre-sized the length was always `numKeys` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
