DonalEvans commented on a change in pull request #6861: URL: https://github.com/apache/geode/pull/6861#discussion_r715154104
########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); Review comment: To prevent possible integer overflow when this value is later cast to an `int`; `numKeys` should be declared as an `int` and this line changed to `numKeys = narrowLongToInt(bytesToLong(argIterator.next()));` ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java ########## @@ -288,6 +289,54 @@ long zcount(SortedSetScoreRangeOptions rangeOptions) { return byteIncr; } + long zinterstore(RegionProvider regionProvider, RedisKey key, List<ZKeyWeight> keyWeights, + ZAggregator aggregator) { + List<RedisSortedSet> sets = new ArrayList<>(keyWeights.size()); + for (ZKeyWeight keyWeight : keyWeights) { + RedisSortedSet set = + regionProvider.getTypedRedisData(REDIS_SORTED_SET, keyWeight.getKey(), false); + + if (set == NULL_REDIS_SORTED_SET) { + continue; + } + + double weight = keyWeight.getWeight(); + RedisSortedSet weightedSet = new RedisSortedSet(Collections.emptyList()); + + for (AbstractOrderedSetEntry entry : set.members.values()) { + OrderedSetEntry existingValue = members.get(entry.member); + if (existingValue == null) { + double score; + // Redis math and Java math are different when handling infinity. Specifically: + // Java: INFINITY * 0 = NaN + // Redis: INFINITY * 0 = 0 + if (weight == 0) { + score = 0; + } else if (weight == 1) { + score = entry.getScore(); + } else if (Double.isInfinite(weight) && entry.score == 0D) { + score = 0D; + } else { + double newScore = entry.score * weight; + if (Double.isNaN(newScore)) { + throw new ArithmeticException(ERROR_OPERATION_PRODUCED_NAN); Review comment: The test that I included here is still failing when run against Geode Redis and passing when run against native Redis. I think that what's needed is a check in the `getSumOfScoresForMember()` method to see if we're about to add positive infinity to negative infinity and if so, not return NaN, but return 0, so that we can match Redis' behaviour. We're already avoiding doing Java math if we know the result would be different from Redis (see the comments just above here about `INFINITY * 0`) so adding in this check isn't deviating from what we've already decided we want to do. ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<ZKeyWeight> keyWeights = new ArrayList<>((int) numKeys); + ZAggregator aggregator = ZAggregator.SUM; + + while (argIterator.hasNext()) { + byte[] arg = argIterator.next(); + + if (keyWeights.size() < numKeys) { + keyWeights.add(new ZKeyWeight(new RedisKey(arg), 1D)); + continue; + } + + arg = toUpperCaseBytes(arg); + if (Arrays.equals(arg, bWEIGHTS)) { + if (!allWeightsAreOne(keyWeights)) { + return RedisResponse.error(ERROR_SYNTAX); + } Review comment: Rather than checking the entire contents of `keyWeights` here (which could potentially be a very long list) it might be better to have a boolean flag called "weightsParsed" or something, which we set to true the first time we parse a `WEIGHTS` argument and return an error if we check it and it's already true. ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<ZKeyWeight> keyWeights = new ArrayList<>((int) numKeys); + ZAggregator aggregator = ZAggregator.SUM; + + while (argIterator.hasNext()) { + byte[] arg = argIterator.next(); + + if (keyWeights.size() < numKeys) { + keyWeights.add(new ZKeyWeight(new RedisKey(arg), 1D)); + continue; + } Review comment: This seems like it could be broken up into two separate loops; one where we parse all the keys (since we know how many there should be), and one where we parse the weights and any aggregate arguments that might be present. That would avoid us having to check the size of `keyWeights` for every iteration after we're done parsing the keys, and would break the method up a bit and make it easier to read. It might be useful to use a `ListIterator` to help with this, since they allow you to begin iterating from a certain index of a List (in this case, the index of the first element after all of the keys): `ListIterator<byte[]> iterator = commandElements.listIterator(numKeys + 2);` ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSetCommandsFunctionExecutor.java ########## @@ -164,6 +174,17 @@ public long zrevrank(RedisKey key, byte[] member) { @Override public long zunionstore(RedisKey destinationKey, List<ZKeyWeight> keyWeights, ZAggregator aggregator) { + List<RedisKey> keysToLock = lockKeys(destinationKey, keyWeights); + + return stripedExecute(destinationKey, keysToLock, + () -> new RedisSortedSet(Collections.emptyList(), new double[] {}).zunionstore( + getRegionProvider(), + destinationKey, keyWeights, aggregator)); + } + + + /************* Helper Methods *************/ + private List<RedisKey> lockKeys(RedisKey destinationKey, List<ZKeyWeight> keyWeights) { Review comment: This method name is potentially misleading, since it doesn't actually lock the keys, just get a list of keys in the appropriate order for locking by the `stripedExecute()` method. ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<ZKeyWeight> keyWeights = new ArrayList<>((int) numKeys); + ZAggregator aggregator = ZAggregator.SUM; + + while (argIterator.hasNext()) { + byte[] arg = argIterator.next(); + + if (keyWeights.size() < numKeys) { + keyWeights.add(new ZKeyWeight(new RedisKey(arg), 1D)); + continue; + } + + arg = toUpperCaseBytes(arg); + if (Arrays.equals(arg, bWEIGHTS)) { + if (!allWeightsAreOne(keyWeights)) { + return RedisResponse.error(ERROR_SYNTAX); + } + for (int i = 0; i < numKeys; i++) { + if (!argIterator.hasNext()) { + return RedisResponse.error(ERROR_SYNTAX); + } + try { + keyWeights.get(i).setWeight(Coder.bytesToDouble(argIterator.next())); + } catch (NumberFormatException nex) { + return RedisResponse.error(ERROR_WEIGHT_NOT_A_FLOAT); + } + } + continue; + } + + if (Arrays.equals(arg, bAGGREGATE)) { + try { + aggregator = ZAggregator.valueOf(Coder.bytesToString(argIterator.next())); + } catch (IllegalArgumentException | NoSuchElementException e) { + return RedisResponse.error(ERROR_SYNTAX); + } + continue; + } + + // End up here if we have more keys than weights + return RedisResponse.error(ERROR_SYNTAX); + } + + if (keyWeights.size() != numKeys) { + return RedisResponse.error(ERROR_SYNTAX); + } + + int bucket = command.getKey().getBucketId(); Review comment: This check should be on the slot ID of the key, not the bucket ID, since each bucket has multiple slots in it. As this is, you could provide keys with non-matching slots and the command would succeed if they happened to be in the same bucket, which would be a significant difference from native Redis' behaviour. ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { Review comment: We should also check that `numKeys` is positive, and if not, return the same error as native Redis: "ERR at least 1 input key is needed for ZUNIONSTORE/ZINTERSTORE" ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<ZKeyWeight> keyWeights = new ArrayList<>((int) numKeys); + ZAggregator aggregator = ZAggregator.SUM; + + while (argIterator.hasNext()) { + byte[] arg = argIterator.next(); + + if (keyWeights.size() < numKeys) { + keyWeights.add(new ZKeyWeight(new RedisKey(arg), 1D)); + continue; + } + + arg = toUpperCaseBytes(arg); + if (Arrays.equals(arg, bWEIGHTS)) { + if (!allWeightsAreOne(keyWeights)) { + return RedisResponse.error(ERROR_SYNTAX); + } + for (int i = 0; i < numKeys; i++) { + if (!argIterator.hasNext()) { + return RedisResponse.error(ERROR_SYNTAX); + } + try { + keyWeights.get(i).setWeight(Coder.bytesToDouble(argIterator.next())); + } catch (NumberFormatException nex) { + return RedisResponse.error(ERROR_WEIGHT_NOT_A_FLOAT); + } + } + continue; + } + + if (Arrays.equals(arg, bAGGREGATE)) { + try { + aggregator = ZAggregator.valueOf(Coder.bytesToString(argIterator.next())); + } catch (IllegalArgumentException | NoSuchElementException e) { + return RedisResponse.error(ERROR_SYNTAX); + } + continue; + } + + // End up here if we have more keys than weights Review comment: This comment is incorrect, since the check on line 76 ensures that we return an error if we have fewer weights than keys. Rather, this return is for when we've finished parsing keys and encounter an option other than `WEIGHTS` or `AGGREGATE` ########## File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/executor/sortedset/ZStoreExecutor.java ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.executor.sortedset; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_SYNTAX; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WEIGHT_NOT_A_FLOAT; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_SLOT; +import static org.apache.geode.redis.internal.netty.Coder.toUpperCaseBytes; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bAGGREGATE; +import static org.apache.geode.redis.internal.netty.StringBytesGlossary.bWEIGHTS; + +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Iterator; +import java.util.List; +import java.util.NoSuchElementException; + +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.executor.AbstractExecutor; +import org.apache.geode.redis.internal.executor.RedisResponse; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.Command; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public abstract class ZStoreExecutor extends AbstractExecutor { + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElements = command.getProcessedCommand(); + + Iterator<byte[]> argIterator = commandElements.iterator(); + // Skip command and destination key + argIterator.next(); + argIterator.next(); + + long numKeys; + try { + numKeys = Coder.bytesToLong(argIterator.next()); + } catch (NumberFormatException ex) { + return RedisResponse.error(ERROR_SYNTAX); + } + + // Rough validation so that we can use numKeys to initialize the array sizes below. + if (numKeys > commandElements.size()) { + return RedisResponse.error(ERROR_SYNTAX); + } + + List<ZKeyWeight> keyWeights = new ArrayList<>((int) numKeys); + ZAggregator aggregator = ZAggregator.SUM; + + while (argIterator.hasNext()) { + byte[] arg = argIterator.next(); + + if (keyWeights.size() < numKeys) { + keyWeights.add(new ZKeyWeight(new RedisKey(arg), 1D)); + continue; + } + + arg = toUpperCaseBytes(arg); + if (Arrays.equals(arg, bWEIGHTS)) { + if (!allWeightsAreOne(keyWeights)) { + return RedisResponse.error(ERROR_SYNTAX); + } + for (int i = 0; i < numKeys; i++) { + if (!argIterator.hasNext()) { + return RedisResponse.error(ERROR_SYNTAX); + } + try { + keyWeights.get(i).setWeight(Coder.bytesToDouble(argIterator.next())); + } catch (NumberFormatException nex) { + return RedisResponse.error(ERROR_WEIGHT_NOT_A_FLOAT); + } + } + continue; + } + + if (Arrays.equals(arg, bAGGREGATE)) { + try { + aggregator = ZAggregator.valueOf(Coder.bytesToString(argIterator.next())); + } catch (IllegalArgumentException | NoSuchElementException e) { + return RedisResponse.error(ERROR_SYNTAX); + } + continue; + } + + // End up here if we have more keys than weights + return RedisResponse.error(ERROR_SYNTAX); + } + + if (keyWeights.size() != numKeys) { Review comment: This check might be unnecessary if the check on line 56 is modified slightly to check if `numKeys` is greater than `commandElements.size() - 2` rather than being greater than `commandElements.size()`. What this line is really checking is that we parsed `numKeys` elements before running out of things to parse. By checking that (excluding the command name and the destination key, hence the -2) there are at minimum enough elements in `commandElements` for us to parse `numKeys` worth, we can know that if we get to this line, then `keyWeights.size()` is guaranteed to be equal to `numKeys`, because we only ever add to `keyWeights()` on line 67, and we stop adding there as soon as we've added `numKeys` elements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
