pivotal-jbarrett commented on a change in pull request #6892:
URL: https://github.com/apache/geode/pull/6892#discussion_r715196997



##########
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -1354,4 +1355,20 @@ protected GatewaySenderEventImpl makeCopy() {
   public void setAcked(boolean acked) {
     isAcked = acked;
   }
+
+  public enum TransactionMetadataDisposition {
+    /**
+     * Transaction metadata should be excluded from the event.
+     */
+    Exclude,
+    /**
+     * Transaction metadata should be included in the event.
+     */
+    Include,
+    /**
+     * Transaction metadata should be included in the event and this is the 
last event in the
+     * transaction.
+     */
+    IncludeLastEvent,

Review comment:
       I would be more include to renaming it `IncludeAsLastEvent` implying 
both the inclusion of the `TransactionId` and the setting of the `isLastEvent` 
flag.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to