pivotal-jbarrett commented on a change in pull request #6892:
URL: https://github.com/apache/geode/pull/6892#discussion_r715198882
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##########
@@ -322,9 +321,11 @@ public GatewaySenderEventImpl(EnumListenerEvent operation,
CacheEvent<?, ?> ce,
}
isConcurrencyConflict = event.isConcurrencyConflict();
- transactionId = event.getTransactionId();
- this.isLastEventInTransaction = isLastEventInTransaction;
-
+ if (transactionMetadataDisposition != Exclude) {
Review comment:
The disposition is now only set to anything other than `Exclude` by when
TX grouping is enabled. The `transactionId` is `null` when
`transactionMetadataDisposition` is `Exclude`. In `toData` the `transactionId`
part is only serialized if it isn't `null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
