jdeppe-pivotal commented on a change in pull request #6861:
URL: https://github.com/apache/geode/pull/6861#discussion_r716645606
##########
File path:
geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RegionProvider.java
##########
@@ -345,6 +345,14 @@ public RedisKeyCommands getKeyCommands() {
return (Set<DistributedMember>) (Set<?>)
partitionedRegion.getRegionAdvisor().adviseDataStore();
}
+ /**
+ * A means to consistently order multiple keys for locking to avoid typical
deadlock situations.
+ * Note that the list of keys is sorted in place.
+ */
+ public void orderForLocking(List<RedisKey> keys) {
+ keys.sort(stripedCoordinator::compareStripes);
+ }
Review comment:
You don't need to use this anymore since locking (and sorting) is
automatically handled in the `LockingStripedCoordinator` now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
