DonalEvans commented on a change in pull request #6895:
URL: https://github.com/apache/geode/pull/6895#discussion_r716924014
##########
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/StatusRedundancyCommandDUnitTest.java
##########
@@ -197,14 +197,24 @@ public void
statusRedundancyWithIncludeRegionReturnsErrorWhenAtLeastOneIncludedR
}
@Test
- public void statusRedundancyReturnsEmptyRegionStatusAsNonRedundantCopies() {
+ public void
statusRedundancyReturnsRegionWithNoBucketsCreatedStatusAsNoRedundantCopies() {
createRegion();
String command = new
CommandStringBuilder(STATUS_REDUNDANCY).getCommandString();
CommandResultAssert commandResult =
gfsh.executeAndAssertThat(command).statusIsSuccess();
verifyGfshOutput(commandResult, Collections.singletonList(EMPTY_REGION),
new ArrayList<>(),
new ArrayList<>());
}
+ @Test
+ public void statusRedundancyReturnsEmptyRegionStatusAsSatisfied() {
Review comment:
To be more accurate, this test name should just say that an empty region
reports redundancy status correctly, since an empty region will not report as
"satisfied" if there aren't enough servers to host that many copies, or if
redundancy isn't actually satisfied due to restarted servers etc. Really, what
the test is showing is that an empty region behaves no different from a region
with entries in it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
