alb3rtobr commented on a change in pull request #6895:
URL: https://github.com/apache/geode/pull/6895#discussion_r717062847
##########
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/StatusRedundancyCommandDUnitTest.java
##########
@@ -197,14 +197,24 @@ public void
statusRedundancyWithIncludeRegionReturnsErrorWhenAtLeastOneIncludedR
}
@Test
- public void statusRedundancyReturnsEmptyRegionStatusAsNonRedundantCopies() {
+ public void
statusRedundancyReturnsRegionWithNoBucketsCreatedStatusAsNoRedundantCopies() {
createRegion();
String command = new
CommandStringBuilder(STATUS_REDUNDANCY).getCommandString();
CommandResultAssert commandResult =
gfsh.executeAndAssertThat(command).statusIsSuccess();
verifyGfshOutput(commandResult, Collections.singletonList(EMPTY_REGION),
new ArrayList<>(),
new ArrayList<>());
}
+ @Test
+ public void statusRedundancyReturnsEmptyRegionStatusAsSatisfied() {
Review comment:
I agree, good catch
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/control/SerializableRegionRedundancyStatusImpl.java
##########
@@ -53,7 +53,7 @@ public
SerializableRegionRedundancyStatusImpl(PartitionedRegion region) {
* @param region The region for which the lowest redundancy should be
calculated.
* @return The redundancy of the least redundant bucket in the region.
*/
- private int calculateLowestRedundancy(PartitionedRegion region) {
+ int calculateLowestRedundancy(PartitionedRegion region) {
int numBuckets = region.getPartitionAttributes().getTotalNumBuckets();
int minRedundancy = Integer.MAX_VALUE;
Review comment:
thanks for your answer Donal
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/control/SerializableRegionRedundancyStatusImpl.java
##########
@@ -53,7 +53,7 @@ public
SerializableRegionRedundancyStatusImpl(PartitionedRegion region) {
* @param region The region for which the lowest redundancy should be
calculated.
* @return The redundancy of the least redundant bucket in the region.
*/
- private int calculateLowestRedundancy(PartitionedRegion region) {
+ int calculateLowestRedundancy(PartitionedRegion region) {
int numBuckets = region.getPartitionAttributes().getTotalNumBuckets();
int minRedundancy = Integer.MAX_VALUE;
Review comment:
@mhansonp is it ok for you to remove the request for changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
