jdeppe-pivotal commented on a change in pull request #6891:
URL: https://github.com/apache/geode/pull/6891#discussion_r723448213
##########
File path:
geode-core/src/upgradeTest/java/org/apache/geode/ClusterCommunicationsDUnitTest.java
##########
@@ -246,28 +255,19 @@ public void createEntryWithBigMessage() {
@Test
public void receiveBigResponse() {
- invokeInEveryVM(
- () ->
InternalDataSerializer.getDSFIDSerializer().registerDSFID(SERIAL_ACKED_MESSAGE,
- SerialAckedMessageWithBigReply.class));
- try {
- int locatorPort = createLocator(getVM(0));
- for (int i = 1; i <= NUM_SERVERS; i++) {
- createCacheAndRegion(getVM(i), locatorPort);
- }
- DistributedMember vm2ID =
- getVM(2).invoke(() ->
cache.getDistributedSystem().getDistributedMember());
- getVM(1).invoke("receive a large direct-reply message", () -> {
- SerialAckedMessageWithBigReply messageWithBigReply = new
SerialAckedMessageWithBigReply();
- await().until(() -> {
- messageWithBigReply.send(Collections.singleton(vm2ID));
- return true;
- });
- });
- } finally {
- invokeInEveryVM(
- () ->
InternalDataSerializer.getDSFIDSerializer().registerDSFID(SERIAL_ACKED_MESSAGE,
- SerialAckedMessage.class));
+ int locatorPort = createLocator(getVM(0));
+ for (int i = 1; i <= NUM_SERVERS; i++) {
+ createCacheAndRegion(getVM(i), locatorPort);
}
+ DistributedMember vm2ID =
+ getVM(2).invoke(() ->
cache.getDistributedSystem().getDistributedMember());
+ getVM(1).invoke("receive a large direct-reply message", () -> {
+ SerialAckedMessageWithBigReply messageWithBigReply = new
SerialAckedMessageWithBigReply();
+ await().until(() -> {
+ messageWithBigReply.send(Collections.singleton(vm2ID));
+ return true;
+ });
Review comment:
It looks like the `await` will catch a hang in the `send` call. If I
break this test by not registering any fixed Ids, then the remote end (of the
`send`) throws an exception but no reply ever comes back. This seems like a
much bigger issue...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
