jdeppe-pivotal commented on a change in pull request #6891:
URL: https://github.com/apache/geode/pull/6891#discussion_r723449425
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/InternalDataSerializer.java
##########
@@ -329,6 +331,17 @@ public void invokeFromData(Object ds, DataInput in)
}).create();
initializeWellKnownSerializers();
dsfidFactory = new DSFIDFactory(dsfidSerializer);
+
+ ServiceLoader<DataSerializableFixedIdLoader> loaders = ServiceLoader.load(
+ DataSerializableFixedIdLoader.class);
+ for (DataSerializableFixedIdLoader loader : loaders) {
+ try {
+ loader.register(dsfidSerializer);
+ } catch (Exception ex) {
+ logger.warn("Data serializable fixed ID loader '" +
loader.getClass().getName() +
+ "' failed", ex);
Review comment:
Which is probably what I did... :( Fixed now.
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/BackwardCompatibilitySerializationDUnitTest.java
##########
@@ -249,6 +248,8 @@ private void resetFlags() {
private static final KnownVersion[] dsfidVersions =
new KnownVersion[] {KnownVersion.GEODE_1_1_0,
KnownVersion.GEODE_1_5_0};
+ static final int TEST_MESSAGE_DSFID = 12345;
+
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
