kamilla1201 commented on a change in pull request #7119:
URL: https://github.com/apache/geode/pull/7119#discussion_r756468945
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1798,6 +1794,46 @@ private void createIoFilter(SocketChannel channel,
boolean clientSocket) throws
}
}
+ private SSLEngine createSslEngine(final InetSocketAddress remoteAddress) {
+ final String hostName;
+ final boolean isSender = remoteMember != null;
Review comment:
`createIoFilter` is used by both sender and receiver and that creates
some confusion: it isn’t obvious what `clientSocket` really means, who and why
sets it to true, and in what cases `remoteMember` can be null.
Yes, before this change, the sender set `clientSocket` to true and the
receiver set it to false. The sender also sets the `remoteMember` while the
receiver doesn’t (it only knows the remote address from the socket channel). So
there is a correlation between `remoteMember` and `clientSocket`, and we wanted
to “document” it in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
