agingade commented on a change in pull request #7119:
URL: https://github.com/apache/geode/pull/7119#discussion_r759309209
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##########
@@ -1798,6 +1794,46 @@ private void createIoFilter(SocketChannel channel,
boolean clientSocket) throws
}
}
+ private SSLEngine createSslEngine(final InetSocketAddress remoteAddress) {
+ final String hostName;
+ final boolean isSender = remoteMember != null;
Review comment:
Can this be a possibility: by the time createSslEngine is called the
remote member has left the cluster (or forced-disconnected)? or SocketChannel
is closed...
Is it a good idea to have a test, where the remote member is made to exit;
right before createSslEngine is called.
Sorry if I am suggesting cases thats not practical...Please ignore if thats
the case...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]