pivotal-jbarrett commented on pull request #7103: URL: https://github.com/apache/geode/pull/7103#issuecomment-983120746
> The title of this PR is confusing. You didn't "make InterestType and DataPolicy enums". I think you should correct this in the description of GEODE-9851. My understanding is you are basically changing how these existing classes are used internally in geode by using an instance of the class instead of its ordinal value. But I didn't see any introduction of Java Enum instances. Good point. `InterestType` was converted to an `enum` [here](https://github.com/apache/geode/pull/7103/files#diff-2dc76d4b46e63d7bdcd6debc3978915ee77d063a109d68c7e23a0ed3f9c58d47R23). The public version of this effectively same "enum" is unchanged to avoid API and ABI issues. `DataPolicy` is public and couldn't be safely changed to an `enum` without breaking ABI, though I am still testing this issue. The API can largely be preserved upon conversion to an `enum`. In the mean time I have deprecated the methods that would be replaced by `enum` generated methods in the future, say Geode 2.0 where we can break the ABI. I will work on the description for a better commit message. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
