DonalEvans commented on a change in pull request #7103:
URL: https://github.com/apache/geode/pull/7103#discussion_r760538155
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/InitialImageOperation.java
##########
@@ -3874,16 +3877,17 @@ private void registerInterestKeys(Map<String, ?>
regionKeys, boolean allKey, Loc
regionsWithInterest.add(regionName);
if (allKey) {
ccn.registerClientInterest(regionName, e.getValue(),
proxy.getProxyID(), interestType,
- isDurable, updatesAsInvalidates, manageEmptyRegions, 0,
false);
+ isDurable, updatesAsInvalidates, manageEmptyRegions,
DataPolicy.EMPTY, false);
} else if (InterestType.REGULAR_EXPRESSION == interestType) {
for (final Object o : asSet(e.getValue())) {
ccn.registerClientInterest(regionName, o, proxy.getProxyID(),
- interestType, isDurable, updatesAsInvalidates,
manageEmptyRegions, 0, false);
+ interestType, isDurable, updatesAsInvalidates,
manageEmptyRegions,
+ DataPolicy.EMPTY, false);
}
} else {
ccn.registerClientInterest(regionName, new
ArrayList<>(asSet(e.getValue())),
proxy.getProxyID(), isDurable, updatesAsInvalidates,
manageEmptyRegions,
- interestType, false);
+ DataPolicy.EMPTY, false);
Review comment:
This seems like a change in behaviour. Previously the value passed as
the `regionDataPolicy` argument to `registerClientInterest()` wasn't fixed, as
`interestType` could take values 0-4 (although if it was 1 then the
`InterestType.REGULAR_EXPRESSION == interestType` check above would prevent us
getting to here). Was this just a bug in the old code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
