agingade commented on a change in pull request #7199:
URL: https://github.com/apache/geode/pull/7199#discussion_r769716240
##########
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/persistence/PersistentRecoveryOrderDUnitTest.java
##########
@@ -1327,8 +1327,19 @@ public void testRecoverAfterConflict() {
vm0.invoke(() -> {
// This should work now
- createReplicateRegion(regionName, getDiskDirs(getVMId()));
- updateEntry("A", "C");
+ try {
+ createReplicateRegion(regionName, getDiskDirs(getVMId()));
+ updateEntry("A", "C");
+ } catch (CacheClosedException cacheClosedException) {
Review comment:
isClosed() checks the isClosing flag; which gets set whiel close is in
progress.
Checking for null is not a bad idea; to determine the cache is completely
closed.
Other option could be using CacheLifecycleListener...Ex:
ModifyColocationIntegrationTest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
