agingade commented on a change in pull request #7199:
URL: https://github.com/apache/geode/pull/7199#discussion_r769730154



##########
File path: 
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/persistence/PersistentRecoveryOrderDUnitTest.java
##########
@@ -1326,6 +1326,10 @@ public void testRecoverAfterConflict() {
     vm1.invoke(() -> getCache().close());
 
     vm0.invoke(() -> {
+      await().untilAsserted(
+          () -> assertThat(
+              
InternalDistributedSystem.getAnyInstance().getCancelCriterion().cancelInProgress())

Review comment:
       Looking at the code related to cancelInProgress(); it looks like it may 
also be returning early, by checking isClosing(). I may be missing 
something...Can you please point me to the path where it shows/checks 
cacelInProgress is returns null after cache is completely closed...




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to