dschneider-pivotal commented on a change in pull request #7205:
URL: https://github.com/apache/geode/pull/7205#discussion_r779038416
##########
File path: geode-docs/tools_modules/geode_for_redis.html.md.erb
##########
@@ -35,13 +35,14 @@ Use gfsh to start at least one server with a command of the
form:
start server \
--name=<serverName> \
--locators=<locatorPort> \
- --geode-for-redis-port=<geodeForRedisPort> \
- --geode-for-redis-bind-address=<geodeForRedisBindAddress> \
- --geode-for-redis-password=<geodeForRedisPassword>
+ --J=-Dgemfire.geode-for-redis-enabled=true \
+ --J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \
+ --J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress> \
+ --J=-Dgemfire.geode-for-redis-password=<geodeForRedisPassword>
```
-If any of the options `geode-for-redis-bind-address`,
`geode-for-redis-password`, or `geode-for-redis-port`
-are included, a <%=vars.product_name%> server with <%=vars.product_name%> for
Redis will be started.
+If the option `geode-for-redis-enabled`, is set to `true`, a
<%=vars.product_name%> server with
Review comment:
I think it is wrong to call "geode-for-redis-enabled" an "option". It
used to be a gfsh option but is no longer. Consider replacing "option" with
"gemfire property".
##########
File path: geode-for-redis/README.md
##########
@@ -34,11 +34,12 @@ Once the locator has started, start at least one server
with a command of the fo
gfsh> start server \
--name=<serverName> \
--locators=localhost[<locatorPort>] \
- --geode-for-redis-port=<geodeForRedisPort> \
- --geode-for-redis-bind-address=<geodeForRedisBindAddress>
+ --J=-Dgemfire.geode-for-redis-enabled=true \
+ --J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \
+ --J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress>
```
-If any of the options `geode-for-redis-bind-address`,
`geode-for-redis-username`, or `geode-for-redis-port` are included, a Geode
server with Geode for Redis will be started.
+If the option `geode-for-redis-enabled` is set to `true`, a Geode server with
Geode for Redis will be started.
Review comment:
option once again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
