nonbinaryprogrammer commented on a change in pull request #7205:
URL: https://github.com/apache/geode/pull/7205#discussion_r779809865
##########
File path: geode-docs/reference/topics/gemfire_properties.html.md.erb
##########
@@ -501,12 +501,6 @@ to true to enable <%=vars.product_name%> for Redis.</td>
<td>false</td>
</tr>
<tr>
-<td>geode-for-redis-password</td>
Review comment:
why remove this one but not the bind address and username?
##########
File path: geode-docs/tools_modules/geode_for_redis.html.md.erb
##########
@@ -35,13 +35,13 @@ Use gfsh to start at least one server with a command of the
form:
start server \
--name=<serverName> \
--locators=<locatorPort> \
- --geode-for-redis-port=<geodeForRedisPort> \
- --geode-for-redis-bind-address=<geodeForRedisBindAddress> \
- --geode-for-redis-password=<geodeForRedisPassword>
+ --J=-Dgemfire.geode-for-redis-enabled=true \
+ --J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \
+ --J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress>
Review comment:
I guess it makes sense since other properties use that format, I just
wanted us to think about if that is the right approach or if we're following a
pattern that doesn't make sense.
##########
File path: geode-docs/tools_modules/geode_for_redis.html.md.erb
##########
@@ -35,13 +35,13 @@ Use gfsh to start at least one server with a command of the
form:
start server \
--name=<serverName> \
--locators=<locatorPort> \
- --geode-for-redis-port=<geodeForRedisPort> \
- --geode-for-redis-bind-address=<geodeForRedisBindAddress> \
- --geode-for-redis-password=<geodeForRedisPassword>
+ --J=-Dgemfire.geode-for-redis-enabled=true \
+ --J=-Dgemfire.geode-for-redis-port=<geodeForRedisPort> \
+ --J=-Dgemfire.geode-for-redis-bind-address=<geodeForRedisBindAddress>
Review comment:
do these have to be gemfire. or could they be geode.? just since we
generally avoid referencing gemfire in geode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
