mmartell commented on a change in pull request #909:
URL: https://github.com/apache/geode-native/pull/909#discussion_r787248431
##########
File path: c-bindings/include/geode/region.h
##########
@@ -40,18 +40,41 @@ APACHE_GEODE_C_EXPORT void apache_geode_Region_PutString(
apache_geode_region_t* region, const char* key, const char* value);
APACHE_GEODE_C_EXPORT void apache_geode_Region_PutByteArray(
- apache_geode_region_t* region, const char* key, const char* value, size_t
size);
+ apache_geode_region_t* region, const char* key, size_t keyLength,
Review comment:
I don't disagree. However, I'm thinking we should consider the single
more powerful apache_geode_Region_Put (line 50), which includes lengths for
both key and value, and do away with all other versions of the Put API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
