pdxcodemonkey commented on a change in pull request #909: URL: https://github.com/apache/geode-native/pull/909#discussion_r787984814
########## File path: c-bindings/src/data_serializable_raw.cpp ########## @@ -0,0 +1,80 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include <iterator> + +// C++ client public headers +#include "geode/DataInput.hpp" +#include "geode/DataOutput.hpp" +#include "geode/internal/DataSerializablePrimitive.hpp" + +// C client public headers +#include "data_serializable_raw.hpp" + +// C client private headers + +using apache::geode::client::DataInput; +using apache::geode::client::DataOutput; + +namespace apache { +namespace geode { +namespace client { +namespace internal { + +DataSerializableRaw::DataSerializableRaw(const int8_t* data, size_t size) { Review comment: To an extent this is a "six of one and half a dozen of another" issue, but I suppose it is a little bit cleaner to just go with one parameter of type `std::vector` in the ctor, then use `std:move` move to copy it into bytes_. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
