kirklund commented on a change in pull request #7299:
URL: https://github.com/apache/geode/pull/7299#discussion_r791831466
##########
File path:
geode-serialization/src/main/java/org/apache/geode/internal/serialization/filter/GlobalSerialFilterConfiguration.java
##########
@@ -38,7 +38,9 @@
private final SerializableObjectConfig serializableObjectConfig;
private final FilterPatternFactory filterPatternFactory;
private final Supplier<Set<String>> sanctionedClassesSupplier;
- private final Consumer<String> logger;
+ private final Consumer<String> infoLogger;
+ private final Consumer<String> warnLogger;
+ private final Consumer<String> errorLogger;
Review comment:
Would it be cleaner and still testable to use a single log4j-api Logger
interface instead of three Consumer? The tests need to differentiate between
three different log levels: INFO, WARN and ERROR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
