kirklund commented on a change in pull request #7299:
URL: https://github.com/apache/geode/pull/7299#discussion_r791837623
##########
File path:
geode-serialization/src/test/java/org/apache/geode/internal/serialization/filter/GlobalSerialFilterConfigurationTest.java
##########
@@ -29,38 +29,60 @@
private SerializableObjectConfig config;
private GlobalSerialFilter globalSerialFilter;
- private Consumer<String> logger;
+ private Consumer<String> infoLogger;
+ private Consumer<String> warnLogger;
+ private Consumer<String> errorLogger;
@Before
public void setUp() {
config = mock(SerializableObjectConfig.class);
globalSerialFilter = mock(GlobalSerialFilter.class);
- logger = uncheckedCast(mock(Consumer.class));
+ infoLogger = uncheckedCast(mock(Consumer.class));
+ warnLogger = uncheckedCast(mock(Consumer.class));
+ errorLogger = uncheckedCast(mock(Consumer.class));
}
@Test
- public void
configureLogs_whenUnsupportedOperationExceptionIsThrown_withCause() {
+ public void configureLogsInfo_whenOperationIsSuccessful() {
Review comment:
I think we should remove `configure` from the beginning of these test
names since it's a `FunctionalInterface` with just one method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
