gaussianrecurrence commented on a change in pull request #891:
URL: https://github.com/apache/geode-native/pull/891#discussion_r813197629
##########
File path: cppcache/src/PdxRemoteWriter.cpp
##########
@@ -49,18 +49,18 @@ PdxRemoteWriter::PdxRemoteWriter(
}
PdxRemoteWriter::PdxRemoteWriter(
- DataOutput& output, std::string pdxClassName,
+ DataOutput& output, std::shared_ptr<PdxType> pdxType,
std::shared_ptr<PdxTypeRegistry> pdxTypeRegistry)
- : PdxLocalWriter(output, nullptr, pdxClassName, pdxTypeRegistry),
+ : PdxLocalWriter(output, pdxType, pdxTypeRegistry),
m_preserveDataIdx(0),
m_currentDataIdx(-1),
m_remoteTolocalMapLength(0) {
- m_preserveData = nullptr;
if (m_pdxType != nullptr) {
Review comment:
Thing is I did leave that because I thought what if pdxType passed were
nullptr, but that's not the way it's intended to be used, so I guess it would
be best to force a coredump if pdxType is nullptr, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
