gaussianrecurrence commented on a change in pull request #891:
URL: https://github.com/apache/geode-native/pull/891#discussion_r813199054
##########
File path: cppcache/src/PdxRemoteWriter.hpp
##########
@@ -22,11 +22,13 @@
#include "PdxLocalWriter.hpp"
+#include <geode/internal/geode_globals.hpp>
+
namespace apache {
namespace geode {
namespace client {
-class PdxRemoteWriter : public PdxLocalWriter {
+class APACHE_GEODE_EXPORT PdxRemoteWriter : public PdxLocalWriter {
Review comment:
This class is exported to allow testing. Thing is I thought there are no
issues from the ABI-side if you added new symbols, rather than whenever you
changed symbols. Am I wrong?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
