dschneider-pivotal commented on a change in pull request #7392:
URL: https://github.com/apache/geode/pull/7392#discussion_r816970995
##########
File path:
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java
##########
@@ -135,6 +161,27 @@ public int getDSFID() {
return REDIS_LIST_ID;
}
+ public int elementInsert(byte[] elementToInsert, byte[] referenceElement,
Review comment:
I think this method also needs to be synchronized to protect against a
concurrent GII which will serialize this RedisList instance. The GII does not
do all the other locking that our redis ops does. So anytime we are making a
structural change that is not safe with a concurrent "toData" call we need to
add synchronization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
