pdxcodemonkey commented on a change in pull request #943:
URL: https://github.com/apache/geode-native/pull/943#discussion_r819992126
##########
File path: cppcache/src/TcrConnection.cpp
##########
@@ -659,16 +656,15 @@ char* TcrConnection::readMessage(size_t* recvLen,
if (isNotificationMessage) {
// fix #752 - do not throw periodic TimeoutException for subscription
// channels to avoid frequent stack trace processing.
- return nullptr;
+ return {nullptr, 0, error};
Review comment:
I do to as a concept, use it all the time in my Python code. Just not a
fan of the C++ syntax, like I said I find it clumsy. Of course, that's true of
a lot of the language :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
