[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #943: GEODE-10098: Removed explicit new and delete in favor of unique_ptr

[GitBox]

pivotal-jbarrett commented on a change in pull request #943:
URL: https://github.com/apache/geode-native/pull/943#discussion_r819997003



##########
File path: cppcache/src/TcrConnection.cpp
##########
@@ -659,16 +656,15 @@ char* TcrConnection::readMessage(size_t* recvLen,
       if (isNotificationMessage) {
         // fix #752 - do not throw periodic TimeoutException for subscription
         // channels to avoid frequent stack trace processing.
-        return nullptr;
+        return {nullptr, 0, error};

Review comment:
       C++17 makes it all good. 
   https://en.cppreference.com/w/cpp/language/structured_binding
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org