ringles commented on a change in pull request #7403: URL: https://github.com/apache/geode/pull/7403#discussion_r834673892
########## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractLTrimIntegrationTest.java ########## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.commands.executor.list; + +import static org.apache.geode.redis.RedisCommandArgumentsTestHelper.assertExactNumberOfArgs; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_TYPE; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.BIND_ADDRESS; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.REDIS_CLIENT_TIMEOUT; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.util.concurrent.atomic.AtomicReference; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import redis.clients.jedis.HostAndPort; +import redis.clients.jedis.JedisCluster; +import redis.clients.jedis.Protocol; + +import org.apache.geode.redis.ConcurrentLoopingThreads; +import org.apache.geode.redis.RedisIntegrationTest; + +public abstract class AbstractLTrimIntegrationTest implements RedisIntegrationTest { + public static final String KEY = "key"; + public static final String PREEXISTING_VALUE = "preexistingValue"; + private JedisCluster jedis; + + @Before + public void setUp() { + jedis = new JedisCluster(new HostAndPort(BIND_ADDRESS, getPort()), REDIS_CLIENT_TIMEOUT); + } + + @After + public void tearDown() { + flushAll(); + jedis.close(); + } + + @Test + public void givenWrongNumOfArgs_returnsError() { + assertExactNumberOfArgs(jedis, Protocol.Command.LTRIM, 3); + } + + @Test + public void withNonListKey_Fails() { + jedis.set("string", PREEXISTING_VALUE); + assertThatThrownBy(() -> jedis.ltrim("string", 0, -1)) + .hasMessage(ERROR_WRONG_TYPE); + } + + @Test + public void withNonExistentKey_returnsNull() { + assertThat(jedis.ltrim("nonexistent", 0, -1)).isEqualTo("OK"); + } + + @Test + public void withNonIntegerRangeSpecifier_Fails() { + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "0", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "-1")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + } + + @Test + public void trimsToSpecifiedRange_givenValidRange() { + initializeTestList(); + + jedis.ltrim(KEY, 0, 0); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 2); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, 2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, -2, -1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, -1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e1"); + } + + @Test + public void trimsToCorrectRange_givenSpecifiersOutsideListSize() { + initializeTestList(); + + jedis.ltrim(KEY, -4, -1); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, -10, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 4); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + } + + private void initializeTestList() { + jedis.del(KEY); + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + } + + @Test + public void removesKey_whenLastElementRemoved() { Review comment: Rechristened. ########## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractLTrimIntegrationTest.java ########## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.commands.executor.list; + +import static org.apache.geode.redis.RedisCommandArgumentsTestHelper.assertExactNumberOfArgs; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_TYPE; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.BIND_ADDRESS; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.REDIS_CLIENT_TIMEOUT; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.util.concurrent.atomic.AtomicReference; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import redis.clients.jedis.HostAndPort; +import redis.clients.jedis.JedisCluster; +import redis.clients.jedis.Protocol; + +import org.apache.geode.redis.ConcurrentLoopingThreads; +import org.apache.geode.redis.RedisIntegrationTest; + +public abstract class AbstractLTrimIntegrationTest implements RedisIntegrationTest { + public static final String KEY = "key"; + public static final String PREEXISTING_VALUE = "preexistingValue"; + private JedisCluster jedis; + + @Before + public void setUp() { + jedis = new JedisCluster(new HostAndPort(BIND_ADDRESS, getPort()), REDIS_CLIENT_TIMEOUT); + } + + @After + public void tearDown() { + flushAll(); + jedis.close(); + } + + @Test + public void givenWrongNumOfArgs_returnsError() { + assertExactNumberOfArgs(jedis, Protocol.Command.LTRIM, 3); + } + + @Test + public void withNonListKey_Fails() { + jedis.set("string", PREEXISTING_VALUE); + assertThatThrownBy(() -> jedis.ltrim("string", 0, -1)) + .hasMessage(ERROR_WRONG_TYPE); + } + + @Test + public void withNonExistentKey_returnsNull() { + assertThat(jedis.ltrim("nonexistent", 0, -1)).isEqualTo("OK"); + } + + @Test + public void withNonIntegerRangeSpecifier_Fails() { + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "0", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "-1")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + } + + @Test + public void trimsToSpecifiedRange_givenValidRange() { + initializeTestList(); + + jedis.ltrim(KEY, 0, 0); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 2); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, 2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, -2, -1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, -1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e1"); + } + + @Test + public void trimsToCorrectRange_givenSpecifiersOutsideListSize() { + initializeTestList(); + + jedis.ltrim(KEY, -4, -1); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, -10, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 4); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + } + + private void initializeTestList() { + jedis.del(KEY); + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + } + + @Test + public void removesKey_whenLastElementRemoved() { + final String keyWithTagForKeysCommand = "{tag}" + KEY; + jedis.lpush(keyWithTagForKeysCommand, "e1", "e2", "e3"); + + jedis.ltrim(keyWithTagForKeysCommand, 0, -4); + assertThat(jedis.llen(keyWithTagForKeysCommand)).isEqualTo(0L); + assertThat(jedis.exists(keyWithTagForKeysCommand)).isFalse(); + } + + @Test + public void removesKey_whenLastElementRemoved_multipleTimes() { Review comment: Yeah, really only there during development for TDD. ########## File path: geode-for-redis/src/integrationTest/java/org/apache/geode/redis/internal/commands/executor/list/AbstractLTrimIntegrationTest.java ########## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.commands.executor.list; + +import static org.apache.geode.redis.RedisCommandArgumentsTestHelper.assertExactNumberOfArgs; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER; +import static org.apache.geode.redis.internal.RedisConstants.ERROR_WRONG_TYPE; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.BIND_ADDRESS; +import static org.apache.geode.test.dunit.rules.RedisClusterStartupRule.REDIS_CLIENT_TIMEOUT; +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + +import java.util.concurrent.atomic.AtomicReference; + +import org.junit.After; +import org.junit.Before; +import org.junit.Test; +import redis.clients.jedis.HostAndPort; +import redis.clients.jedis.JedisCluster; +import redis.clients.jedis.Protocol; + +import org.apache.geode.redis.ConcurrentLoopingThreads; +import org.apache.geode.redis.RedisIntegrationTest; + +public abstract class AbstractLTrimIntegrationTest implements RedisIntegrationTest { + public static final String KEY = "key"; + public static final String PREEXISTING_VALUE = "preexistingValue"; + private JedisCluster jedis; + + @Before + public void setUp() { + jedis = new JedisCluster(new HostAndPort(BIND_ADDRESS, getPort()), REDIS_CLIENT_TIMEOUT); + } + + @After + public void tearDown() { + flushAll(); + jedis.close(); + } + + @Test + public void givenWrongNumOfArgs_returnsError() { + assertExactNumberOfArgs(jedis, Protocol.Command.LTRIM, 3); + } + + @Test + public void withNonListKey_Fails() { + jedis.set("string", PREEXISTING_VALUE); + assertThatThrownBy(() -> jedis.ltrim("string", 0, -1)) + .hasMessage(ERROR_WRONG_TYPE); + } + + @Test + public void withNonExistentKey_returnsNull() { + assertThat(jedis.ltrim("nonexistent", 0, -1)).isEqualTo("OK"); + } + + @Test + public void withNonIntegerRangeSpecifier_Fails() { + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "0", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "-1")) + .hasMessage(ERROR_NOT_INTEGER); + assertThatThrownBy(() -> jedis.sendCommand(KEY, Protocol.Command.LTRIM, KEY, + "not-an-integer", "not-an-integer")) + .hasMessage(ERROR_NOT_INTEGER); + } + + @Test + public void trimsToSpecifiedRange_givenValidRange() { + initializeTestList(); + + jedis.ltrim(KEY, 0, 0); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + + initializeTestList(); + + jedis.ltrim(KEY, 0, 2); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, 2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(3); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, 1, -2); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e2"); + + initializeTestList(); + + jedis.ltrim(KEY, -2, -1); + assertThat(jedis.llen(KEY)).isEqualTo(2); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e1"); + + initializeTestList(); + + jedis.ltrim(KEY, -1, -1); + assertThat(jedis.llen(KEY)).isEqualTo(1); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e1"); + } + + @Test + public void trimsToCorrectRange_givenSpecifiersOutsideListSize() { + initializeTestList(); + + jedis.ltrim(KEY, -4, -1); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, -10, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 4); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + + jedis.ltrim(KEY, 0, 10); + assertThat(jedis.llen(KEY)).isEqualTo(4); + assertThat(jedis.lindex(KEY, 0)).isEqualTo("e4"); + assertThat(jedis.lindex(KEY, 1)).isEqualTo("e3"); + assertThat(jedis.lindex(KEY, 2)).isEqualTo("e2"); + assertThat(jedis.lindex(KEY, 3)).isEqualTo("e1"); + } + + private void initializeTestList() { + jedis.del(KEY); + jedis.lpush(KEY, "e1", "e2", "e3", "e4"); + } + + @Test + public void removesKey_whenLastElementRemoved() { + final String keyWithTagForKeysCommand = "{tag}" + KEY; + jedis.lpush(keyWithTagForKeysCommand, "e1", "e2", "e3"); + + jedis.ltrim(keyWithTagForKeysCommand, 0, -4); + assertThat(jedis.llen(keyWithTagForKeysCommand)).isEqualTo(0L); + assertThat(jedis.exists(keyWithTagForKeysCommand)).isFalse(); + } + + @Test + public void removesKey_whenLastElementRemoved_multipleTimes() { + final String keyWithTagForKeysCommand = "{tag}" + KEY; + jedis.lpush(keyWithTagForKeysCommand, "e1", "e2", "e3"); + + jedis.ltrim(keyWithTagForKeysCommand, 0, -4); + jedis.ltrim(keyWithTagForKeysCommand, 0, -4); + + assertThat(jedis.exists(keyWithTagForKeysCommand)).isFalse(); + } + + @Test + public void withConcurrentLPush_returnsCorrectValue() { + String[] valuesInitial = new String[] {"un", "deux", "trois"}; + String[] valuesToAdd = new String[] {"plum", "peach", "orange"}; + jedis.lpush(KEY, valuesInitial); + + final AtomicReference<String> lpopReference = new AtomicReference<>(); + new ConcurrentLoopingThreads(1000, + i -> jedis.lpush(KEY, valuesToAdd), + i -> jedis.ltrim(KEY, 0, 2), + i -> lpopReference.set(jedis.lpop(KEY))) + .runWithAction(() -> { + assertThat(lpopReference).satisfiesAnyOf( + lpopResult -> assertThat(lpopReference.get()).isEqualTo("orange"), + lpopResult -> assertThat(lpopReference.get()).isEqualTo("troix")); + jedis.del(KEY); + jedis.lpush(KEY, valuesInitial); + }); Review comment: When the test was written, we didn't have LRANGE. Reworked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
