ringles commented on a change in pull request #7403: URL: https://github.com/apache/geode/pull/7403#discussion_r834702712
########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LTrimExecutor.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.commands.executor.list; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER; + +import java.util.List; + +import org.apache.geode.cache.Region; +import org.apache.geode.redis.internal.commands.Command; +import org.apache.geode.redis.internal.commands.executor.CommandExecutor; +import org.apache.geode.redis.internal.commands.executor.RedisResponse; +import org.apache.geode.redis.internal.data.RedisData; +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public class LTrimExecutor implements CommandExecutor { + private static final int startIndex = 2; + private static final int stopIndex = 3; + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElems = command.getProcessedCommand(); + Region<RedisKey, RedisData> region = context.getRegion(); + RedisKey key = command.getKey(); + + long start; + long end; + + try { + start = Coder.bytesToLong(commandElems.get(startIndex)); + end = Coder.bytesToLong(commandElems.get(stopIndex)); Review comment: Demoted. ########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/commands/executor/list/LTrimExecutor.java ########## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more contributor license + * agreements. See the NOTICE file distributed with this work for additional information regarding + * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. You may obtain a + * copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software distributed under the License + * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express + * or implied. See the License for the specific language governing permissions and limitations under + * the License. + */ +package org.apache.geode.redis.internal.commands.executor.list; + +import static org.apache.geode.redis.internal.RedisConstants.ERROR_NOT_INTEGER; + +import java.util.List; + +import org.apache.geode.cache.Region; +import org.apache.geode.redis.internal.commands.Command; +import org.apache.geode.redis.internal.commands.executor.CommandExecutor; +import org.apache.geode.redis.internal.commands.executor.RedisResponse; +import org.apache.geode.redis.internal.data.RedisData; +import org.apache.geode.redis.internal.data.RedisKey; +import org.apache.geode.redis.internal.netty.Coder; +import org.apache.geode.redis.internal.netty.ExecutionHandlerContext; + +public class LTrimExecutor implements CommandExecutor { + private static final int startIndex = 2; + private static final int stopIndex = 3; + + @Override + public RedisResponse executeCommand(Command command, ExecutionHandlerContext context) { + List<byte[]> commandElems = command.getProcessedCommand(); + Region<RedisKey, RedisData> region = context.getRegion(); + RedisKey key = command.getKey(); Review comment: Minorly updated. ########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ########## @@ -221,6 +222,63 @@ public int llen() { return elementList.size(); } + /** + * @param start the index of the first element to retain + * @param end the index of the last element to retain + * @param region the region this instance is stored in + * @param key the name of the list to pop from + * @return the element actually popped + */ + public byte[] ltrim(long start, long end, Region<RedisKey, RedisData> region, + RedisKey key) { + int length = elementList.size(); + int retainStart = 0; + int retainEnd = length; + int boundedStart = getBoundedStartIndex(start, length); + int boundedEnd = getBoundedEndIndex(end, length); + RetainElementsByIndexRange retainElementsByRange; + + if (boundedStart > boundedEnd || boundedStart == length) { + // Remove everything + retainStart = -1; Review comment: Simplified. ########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ########## @@ -221,6 +222,63 @@ public int llen() { return elementList.size(); } + /** + * @param start the index of the first element to retain + * @param end the index of the last element to retain + * @param region the region this instance is stored in + * @param key the name of the list to pop from + * @return the element actually popped + */ + public byte[] ltrim(long start, long end, Region<RedisKey, RedisData> region, Review comment: Updated. ########## File path: geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisList.java ########## @@ -221,6 +222,63 @@ public int llen() { return elementList.size(); } + /** + * @param start the index of the first element to retain + * @param end the index of the last element to retain + * @param region the region this instance is stored in + * @param key the name of the list to pop from + * @return the element actually popped + */ + public byte[] ltrim(long start, long end, Region<RedisKey, RedisData> region, + RedisKey key) { + int length = elementList.size(); + int retainStart = 0; + int retainEnd = length; + int boundedStart = getBoundedStartIndex(start, length); + int boundedEnd = getBoundedEndIndex(end, length); + RetainElementsByIndexRange retainElementsByRange; + + if (boundedStart > boundedEnd || boundedStart == length) { + // Remove everything + retainStart = -1; + } else { + if (boundedStart > retainStart) { + retainStart = boundedStart; + } + if (boundedEnd <= retainEnd) { + retainEnd = boundedEnd; + } Review comment: Eliminated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
