Bill commented on a change in pull request #7449:
URL: https://github.com/apache/geode/pull/7449#discussion_r835652079
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##########
@@ -373,6 +397,9 @@ public void doneReadingDirectAck(ByteBuffer
unwrappedBuffer) {
@Override
public synchronized void close(SocketChannel socketChannel) {
+
+ assert socketChannel.isBlocking();
+
Review comment:
Code inside this method (not modified by this PR):
```java
while (myNetData.hasRemaining()) {
socketChannel.write(myNetData);
}
```
Writes in what would be a hot loop if the channel was in non-blocking mode.
Rather than changing that loop, I added this assertion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
