Bill commented on a change in pull request #7449:
URL: https://github.com/apache/geode/pull/7449#discussion_r835653789
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##########
@@ -402,6 +436,10 @@ public synchronized void close(SocketChannel
socketChannel) {
socketChannel.write(myNetData);
}
}
+ if (result != null && result.getStatus() != CLOSED) {
+ throw new SSLHandshakeException(
+ "Error closing SSL session. Status=" + result.getStatus());
+ }
Review comment:
Not thrilled with having to null-check here. See the comment in the loop
body around line 424 for an explanation of why this rearrangement was necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
