DonalEvans commented on code in PR #7558:
URL: https://github.com/apache/geode/pull/7558#discussion_r846822181
##########
geode-for-redis/src/test/java/org/apache/geode/redis/internal/data/delta/SetTimestampDeltaUnitTest.java:
##########
@@ -23,18 +23,19 @@
import java.io.DataOutputStream;
import org.junit.Test;
+import org.junit.runner.RunWith;
-import org.apache.geode.redis.internal.data.delta.ReplaceByteArrayAtOffset;
-
-public class DeltaClassesJUnitTest {
+import org.apache.geode.redis.internal.data.RedisString;
+import org.apache.geode.test.junit.runners.GeodeParamsRunner;
+@RunWith(GeodeParamsRunner.class)
+public class SetTimestampDeltaUnitTest {
@Test
- public void testReplaceByteArrayAtOffsetForRedisString() throws Exception {
+ public void testSetTimestampDelta() throws Exception {
Review Comment:
Yeah, it's a public, non-final method, so it's entirely possible that it
could get overridden, even if there's no reason to right now. One alternative
solution could be to make the method `final` so that we know it can't be
overridden.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
