ringles commented on code in PR #7558:
URL: https://github.com/apache/geode/pull/7558#discussion_r847422723
##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSortedSet.java:
##########
@@ -178,7 +178,8 @@ public boolean equals(Object o) {
});
}
- protected synchronized MemberAddResult memberAdd(byte[] memberToAdd, double
scoreToAdd) {
+ @VisibleForTesting
+ public synchronized MemberAddResult memberAdd(byte[] memberToAdd, double
scoreToAdd) {
Review Comment:
Had to make that constructor public, but that's even more reasonable.
##########
geode-for-redis/src/main/java/org/apache/geode/redis/internal/data/RedisSet.java:
##########
@@ -409,7 +409,7 @@ public void fromData(DataInput in) throws IOException,
ClassNotFoundException {
}
@VisibleForTesting
- synchronized boolean membersAdd(byte[] memberToAdd) {
+ public synchronized boolean membersAdd(byte[] memberToAdd) {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
