zsitole commented on code in PR #7584:
URL: https://github.com/apache/geode/pull/7584#discussion_r850355883
##########
geode-core/src/main/java/org/apache/geode/internal/cache/execute/AbstractExecution.java:
##########
@@ -504,8 +508,16 @@ private void handleException(Throwable functionException,
final Function fn,
((InternalResultSender) sender).setException(functionException);
}
} else {
- logger.warn("Exception occurred on local node while executing Function:",
- functionException);
+ if (AbstractExecution.SUPPRESS_FUNCTION_EXCEPTION_LOGGING
+ && functionException instanceof FunctionException) {
+ if (logger.isDebugEnabled()) {
Review Comment:
Thanks @pivotal-jbarrett, I agreed with you, log4j with markers approach may
be more careful and flexible. I've added a new commit with the changes.
@albertogpz Do you have any objections to it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
