[GitHub] [geode] zsitole commented on a diff in pull request #7584: GEODE-10231 : Add configuration for suppressing FunctionException logging

[GitBox]

zsitole commented on code in PR #7584:
URL: https://github.com/apache/geode/pull/7584#discussion_r851232611


##########
geode-core/src/main/java/org/apache/geode/internal/cache/execute/ServerToClientFunctionResultSender.java:
##########
@@ -321,16 +325,8 @@ public synchronized void setException(Throwable exception) 
{
           }
           String exceptionMessage = exception.getMessage() != null ? 
exception.getMessage()
               : "Exception occurred during function execution";
-          if (AbstractExecution.SUPPRESS_FUNCTION_EXCEPTION_LOGGING
-              && exception instanceof FunctionException) {
-            if (logger.isDebugEnabled()) {
-              logger.debug(String.format("Exception on server while executing 
function : %s",
-                  fn), exception);
-            }
-          } else {
-            logger.warn(String.format("Exception on server while executing 
function : %s",
-                fn), exception);
-          }
+          logger.warn(exception instanceof FunctionException ? 
FUNCTION_EXCEPTION_MARKER : null,
+              String.format("Exception on server while executing function : 
%s", fn), exception);

Review Comment:
   Updated



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org