[GitHub] [geode] mhansonp commented on a diff in pull request #7493: GEODE-10155: Avoid threads hanging when function execution times-out

[GitBox]

mhansonp commented on code in PR #7493:
URL: https://github.com/apache/geode/pull/7493#discussion_r859049838


##########
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/PRClientServerTestBase.java:
##########
@@ -120,7 +123,8 @@ protected boolean shouldRegisterFunctionsOnClient() {
     return ExecuteFunctionMethod.ExecuteFunctionByObject == 
functionExecutionType;
   }
 
-  ArrayList createCommonServerAttributes(String regionName, PartitionResolver 
pr, int red,
+  ArrayList<Object> createCommonServerAttributes(String regionName, 
PartitionResolver<?, ?> pr,

Review Comment:
   As seen here createCommonServerAttributes returns ArrayList<Object>



##########
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/PRClientServerTestBase.java:
##########
@@ -131,26 +135,26 @@ ArrayList createCommonServerAttributes(String regionName, 
PartitionResolver pr,
     return commonAttributes;
   }
 
-  public static Integer createCacheServer(ArrayList commonAttributes, Integer 
localMaxMemory) {
+  public static Integer createCacheServer(ArrayList<?> commonAttributes, 
Integer localMaxMemory) {

Review Comment:
   commonAttributes is of type Object



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org