mhansonp commented on code in PR #7493: URL: https://github.com/apache/geode/pull/7493#discussion_r859055061
########## geode-core/src/distributedTest/java/org/apache/geode/internal/cache/execute/PRClientServerTestBase.java: ########## @@ -368,6 +377,33 @@ private static void createNoSingleHopCacheClient(String host, Integer port1, Int assertNotNull(region); } + private static void createNoSingleHopCacheClient(String host, + Integer port1, Integer port2, Integer port3, int connectTimeout) { + CacheServerTestUtil.disableShufflingOfEndpoints(); + + Pool p; + try { + PoolFactory factory = PoolManager.createFactory().addServer(host, port1) + .addServer(host, port2).addServer(host, port3).setPingInterval(2000) + .setSubscriptionEnabled(true).setReadTimeout(2000) + .setSocketBufferSize(1000).setRetryAttempts(0) + .setSocketConnectTimeout(connectTimeout) + .setPRSingleHopEnabled(false); + + p = factory.create("PRClientServerTestBase"); + } finally { + CacheServerTestUtil.enableShufflingOfEndpoints(); + } + pool = (PoolImpl) p; + AttributesFactory factory = new AttributesFactory(); Review Comment: If you look at what is being put in the region, it varies. I prefer Object to ?, but I will defer to your opinion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org