yozaner1324 commented on code in PR #7631:
URL: https://github.com/apache/geode/pull/7631#discussion_r861161715
##########
geode-core/src/distributedTest/java/org/apache/geode/management/DiskManagementDUnitTest.java:
##########
@@ -394,7 +394,7 @@ private MemberMXBean awaitMemberMXBeanProxy(final
DistributedMember member) {
return service.getMBeanProxy(objectName, MemberMXBean.class);
}
- private void await(final AsyncInvocation createPersistentRegionAsync)
+ private void await(final AsyncInvocation<?> createPersistentRegionAsync)
Review Comment:
While it could be, since this method only calls `await(..)`, there is no
reason it needs to be `Void` specifically. My preference is to leave method
arguments more generic where possible while making return types and variables
as specific as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
