DonalEvans commented on code in PR #7631:
URL: https://github.com/apache/geode/pull/7631#discussion_r861177626


##########
geode-core/src/distributedTest/java/org/apache/geode/management/DiskManagementDUnitTest.java:
##########
@@ -394,7 +394,7 @@ private MemberMXBean awaitMemberMXBeanProxy(final 
DistributedMember member) {
     return service.getMBeanProxy(objectName, MemberMXBean.class);
   }
 
-  private void await(final AsyncInvocation createPersistentRegionAsync)
+  private void await(final AsyncInvocation<?> createPersistentRegionAsync)

Review Comment:
   I'd definitely agree if this was a public method or in product code, but 
since it's a private method in a test class, we can be pretty certain that the 
way it's called isn't going to change. In fact, since it's a one-line method, 
it could probably just be inlined, making this whole discussion moot.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to