gaussianrecurrence commented on code in PR #970:
URL: https://github.com/apache/geode-native/pull/970#discussion_r872129402
##########
cppcache/include/geode/DataInput.hpp:
##########
@@ -452,19 +452,19 @@ class APACHE_GEODE_EXPORT DataInput {
DataInput& operator=(DataInput&&) = default;
protected:
+ const uint8_t* m_buf;
+ const uint8_t* m_bufHead;
Review Comment:
Naming notation for member attributes in Geode Native follows lowerCamelCase
with _ as a postfix, to indicate that it's a member variable. As example
'm_buf' would rather be 'buf_'. Usually whenever we make a change that touches
part of the code with the old notation (m_...) the idea is to change it to the
right notation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
